[#CHIN-77] Compass module is not hiding Blizzard's minimap compass on login/reloadui

Chinchilla

Compass module is not hiding Blizzard's minimap compass on login/reloadui

Created: 18/May/08 02:47 PM Updated: 29/May/08 01:53 AM

Component/s:

None

Affects Version/s:

None

Fix Version/s:

None

WoW Language:

English (enUS)

Description

« Hide

I recently noticed that Blizzard's default compass is still showing on login/reloadui even though I have the Compass module enabled. If I toggle the Compass module off and back on, it then hides the Blizzard compass. Also, the Show/Hide North toggle does nothing.

All

Comments

Change History

Sort Order:

[ Permlink | « Hide ]

George Buford - 28/May/08 12:37 AM - edited

Here's my solution to this problem. I *wanted* to call hideBlizzDirections() from the Compass initialization code, but that didn't seem to work anywhere I could find. I'm not even remotely skilled at LUA, though, so perhaps someone who is can find the right spot to do exactly that.

What I did, in Compass.lua, is replace:

local function repositionCompass()
local angle = 0
if rotateMinimap then
angle = MiniMapCompassRing:GetFacing()
end

with:

local function repositionCompass()
local angle = 0
if rotateMinimap then
angle = MiniMapCompassRing:GetFacing()
MiniMapCompassRing:Hide()
else
MinimapNorthTag:Hide()
end

This seems to work perfectly for me, with the compass on or off, but I don't know how much extra CPU usage is being hit by this call happening every bloody time. Like I say, I'd rather see this in the Compass initialization code, but I r teh dum.

Edit: Bah. Can't figure out how to get indentation to show in comments here. I assume anyone reading this is smart enough to indent it properly.

[ Permlink | « Hide ]

Ben Shadwick - 29/May/08 12:45 AM

Should be fixed in r75444.